From cc818bad1c9e8a154c4935cb24bf03a638088cc1 Mon Sep 17 00:00:00 2001 From: Linkjay <5216518+linkjayy@users.noreply.github.com> Date: Sun, 25 Feb 2018 12:07:59 -0800 Subject: [PATCH] Add URL-Encoding to base64 Adding QByteArray::Base64UrlEncoding to the args of imgData.toBase64() will add better compatibility when sending it over to something like PHP or JS. Essentially, it replaces all spaces with - . You could also do QByteArray::Base64Encoding which will replace all spaces with + instead of -. However, the - tends to work better amongst other things. Either one is better than nothing. --- src/uploaders/customuploader.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/uploaders/customuploader.cpp b/src/uploaders/customuploader.cpp index d562fe3..7d5ab5b 100644 --- a/src/uploaders/customuploader.cpp +++ b/src/uploaders/customuploader.cpp @@ -265,7 +265,7 @@ QJsonObject recurseAndReplace(QJsonObject &body, QByteArray &data, QString forma void CustomUploader::doUpload(QByteArray imgData, QString format) { auto h = getHeaders(headers, format, this->rFormat); QByteArray data; - if (base64) imgData = imgData.toBase64(); + if (base64) imgData = imgData.toBase64(QByteArray::Base64UrlEncoding); switch (this->rFormat) { case RequestFormat::PLAIN: {